Update ec network normalize to support variable subsitutions#182
Open
Update ec network normalize to support variable subsitutions#182
Conversation
jameshiebert
requested changes
Jul 11, 2025
Contributor
jameshiebert
left a comment
There was a problem hiding this comment.
Looks great overall, but just a (hopefully) small change to request.
crmprtd/networks/ec/normalize.py
Outdated
|
|
||
| def normalize(file_stream): | ||
| return swob_ml_normalize( | ||
|
|
Contributor
There was a problem hiding this comment.
I'm always skeptical when a patch adds LOCs to our repo. :) The approach you've taken here is reasonable, but I don't think that this is (or will be) specific to ECCC. Could you take what you've done here and incorporate it into the swob_ml module? Then if other networks change their variable names in the future, we will have an easy place to add variable mappings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated crmprtd based on bc_hydro network variable substitutions across to the ec network as well.
Current setup does the following variables:
Some unknowns for me due to unfamiliarity with the project leaves me with the following questions: