Skip to content

add native routine registration#15

Open
edzer wants to merge 4 commits intopacificclimate:masterfrom
edzer:master
Open

add native routine registration#15
edzer wants to merge 4 commits intopacificclimate:masterfrom
edzer:master

Conversation

@edzer
Copy link
Contributor

@edzer edzer commented Apr 24, 2017

No description provided.

@jameshiebert
Copy link
Contributor

Thanks for taking a crack at this! I was unaware of the advantages of registering 'native routines', so I'm glad you saw that message on R-devel.

The tests for this PR failed for a reason unrelated to the code itself... the TravisCI build environment is currently in flux with the EOL of Ubuntu:precise.

I have upgraded the build environment for this repo, so could you rebase your changes against the master branch and ensure that the tests pass correctly?

@edzer
Copy link
Contributor Author

edzer commented Apr 25, 2017

I also noted a regression on CRAN checks, with OSX release. This takes affects downstream packages too; it may have to do with the new R release, but we probably need to contact CRAN (Simon Urbanek) if it persists.

@jameshiebert
Copy link
Contributor

No, we shouldn't need to contact CRAN about this at all. Pretty sure that it's just related to the TravisCI build environment. I already configured Rudunits2's build to use the new TravisCI build environment (as one can see here). So you should simply need to rebase or merge your master with mine to pick up those changes.

@edzer
Copy link
Contributor Author

edzer commented Apr 25, 2017

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants