Add BetterReload support #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I read about an interesting issue regarding the Bukkit
/reloadcommand where one of GUIShop's classes was unable to be casted to itself. This is one of many ridiculous problems I've seen with the Bukkit/reloadcommand - and one of many that I'm hoping to prevent.This pull request adds support for BetterReload - a plugin that overrides the
/reloadcommand and sends out an event in its place to plugins that can either be handled or ignored. This leaves the reloading process up to plugins and leaves no sketchy behavior in the process.This is a completely optional dependency, only having any function when the BetterReload plugin is installed alongside GUIShop.
For more information about BetterReload here are some links:
Source Code
Documentation
SpigotMC
Modrinth
Thank you so much for your time, and have a great day!