Added tests for validating LPM byte alignment when bitwidth not divisible by 8 #627
+220
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is not a mutliple of 8 Signed-off-by: Shrivastava, Shweta <[email protected]>
Signed-off-by: Shrivastava, Shweta <[email protected]>
Signed-off-by: Shrivastava, Shweta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds test cases to test byte alignment when LPM bitwidth is not divisible by 8 (so far the repo only had tests for cases when bitwidth is divisible by 8). Adding these tests revealed a bug which caused these test cases to fail because expected number of trailing zeros (as per current expectations by PI) was calculated incorrectly. This commit also includes fix for the bug.
These tests will also be useful for validating an eventual fix to this issue: #625