feat(a11y+vocab): single dialog landmark, focus trap, copy scrub - #5
Merged
Merged
Conversation
…y scrub
Modal now owns the dialog landmark (role, aria-modal, aria-labelledby),
traps Tab between focusables, captures and restores focus on open/close.
Removes the nested role="dialog" from ContactSupport's ChatLoadingView,
ChatErrorView, and Support's DialogContent so screen readers see a single
valid dialog per surface.
User-facing copy scrubbed for internal terms:
- "merchant" / "mediator" / "fulfillment partner" → neutral language
("support team", "your order", "the other side")
- "Your report is on chain" → "Your support request is registered"
- Drops the tx hash from SubmittedView (chain detail not user-relevant)
- "Finding merchant" badge → "Matching"
- Stepper label "Merchant" → "Matching"
- "View dispute" launcher → "View report"
- Drops the OFP/FPM disclosure paragraph from the Support dialog
Tests + types + build all green. Vitest 55 passed, node:test 70 passed.
5 tasks
vvictor-dev
pushed a commit
to vvictor-dev/widgets
that referenced
this pull request
Aug 22, 2026
…y scrub (p2pdotme#5) Modal now owns the dialog landmark (role, aria-modal, aria-labelledby), traps Tab between focusables, captures and restores focus on open/close. Removes the nested role="dialog" from ContactSupport's ChatLoadingView, ChatErrorView, and Support's DialogContent so screen readers see a single valid dialog per surface. User-facing copy scrubbed for internal terms: - "merchant" / "mediator" / "fulfillment partner" → neutral language ("support team", "your order", "the other side") - "Your report is on chain" → "Your support request is registered" - Drops the tx hash from SubmittedView (chain detail not user-relevant) - "Finding merchant" badge → "Matching" - Stepper label "Merchant" → "Matching" - "View dispute" launcher → "View report" - Drops the OFP/FPM disclosure paragraph from the Support dialog Tests + types + build all green. Vitest 55 passed, node:test 70 passed. Co-authored-by: gitchadd <gitchad@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modalis now the single owner of the dialog landmark (role=dialog,aria-modal,aria-labelledby). Focus is trapped between focusables and returned to the launcher on close. Nestedrole="dialog"removed fromContactSupport's loading/error views andSupport'sDialogContentso screen readers see a single valid landmark per surface.SubmittedView. "View dispute" launcher → "View report". OFP/FPM disclosure paragraph removed.Test plan
npm run typecheck(clean)npm test(55 passed)node --experimental-strip-types --test 'src/core/*.test.ts'(70 passed)npm run build(CJS + DTS success)🤖 Generated with Claude Code