Skip to content

Prevent positive reward for allowing enemies to heal #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
douglasrizzo wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Prevent positive reward for allowing enemies to heal #76

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8042fdc
Addresses #72
douglasrizzo Jul 9, 2021
7909eff
Merge branch 'patch-1'
douglasrizzo Jul 29, 2021
0bb6425
Merge remote-tracking branch 'oxwhirl/master' into patch-1
douglasrizzo Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion smac/env/starcraft2/starcraft2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,7 @@ def reward_battle(self):
delta_enemy += prev_health - e_unit.health - e_unit.shield

if self.reward_only_positive:
reward = abs(delta_enemy + delta_deaths) # shield regeneration
reward = max(0, delta_enemy + delta_deaths) # shield regeneration
else:
reward = delta_enemy + delta_deaths - delta_ally

Expand Down