Use pyHMMER to get rid of binary dependency on HMMER#38
Open
prihoda wants to merge 3 commits intooxpig:masterfrom
Open
Use pyHMMER to get rid of binary dependency on HMMER#38prihoda wants to merge 3 commits intooxpig:masterfrom
prihoda wants to merge 3 commits intooxpig:masterfrom
Conversation
Closed
|
Hi, interested party here. Any updates on this front? Would love to see this fully implemented :) Thank you for your amazing work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step towards enabling
pip install anarci.. I'm not sure if any other changes to setup.py will be needed to get there, we would need to try that out.This way, ANARCI can be installed using:
Speed is unaffected, I've observed just a slight increase in duration similar to the one reported here: https://github.com/althonos/pyhmmer#%EF%B8%8F-benchmarks
I'd be happy to hear your thoughts.