Accounting for the possibility of a delete-state in function check_for_j.#10
Open
grigoryang wants to merge 1 commit intooxpig:masterfrom
Open
Accounting for the possibility of a delete-state in function check_for_j.#10grigoryang wants to merge 1 commit intooxpig:masterfrom
grigoryang wants to merge 1 commit intooxpig:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On occasion, line 744 in anarcy.py (line reading jRegion = [ (state, index+cys_si+1) for state, index in re_states[0] if state[0] >= 117 ]) fails with an error about adding int and NoneType. This is because the value index can end up being None if the current state in the state vector is a delete state (see _hmm_alignment_to_states). I would be very curious to know if you think my fix is correct. Please let me know and hope this helps.