Odds and ends: memory controls, contiguous, optional rms_norm weight - #367
Merged
Conversation
dcvz
marked this pull request as ready for review
September 1, 2026 05:12
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the pre-bump feature gaps flagged by community PRs, through the conformance pipeline:
mlx_rs::memory— the complete 9-function allocator family (active/cache/peak observations, clear_cache, reset_peak, memory/cache/wired limits; setters return the previous value like the C API). Serial RAII-restoring integration tests; no oracle corpus since the figures are machine-dependent. Supersedes feat: add memory::set_memory_limit and memory::get_memory_limit #346, thanks @dschulmeist.Array::contiguous()+ContiguousOptions— row-major materialization, andAsSliceError::NotContiguousfinally points at a concrete remedy. Exact-bit conformance cases over transposed/sliced/broadcast views incl. signed zero and fixed NaN payloads. Supersedes the op half of feat: add contiguity check, contiguous() op, and core fixes #326, thanks @ymote.fast::rms_norm(x, weight: Option<&Array>, eps)— genuine absence (C passes the empty handle), nn::RmsNorm unchanged as weighted. Newfastconformance suite with None/weighted/wrong-shape cases + mutations. Supersedes fast::rms_norm: accept Option<&Array> for weight #347, thanks @Ogilthorp3.Evidence: full suite 1080/0, FFI leak gate pass (0 bytes, memory test binary included), verify-ledger + verify-oracle-boundary pass, API baseline blessed.
🤖 Generated with Claude Code