feat(skills): recursive discovery + knowledge category (Phase B) - #18
Merged
Conversation
…ir; doc/test polish - Fix 1: move node_modules/pkg fixture to root level so is_excluded_dir actually runs; add a hidden-dir case (.hidden-wip) for extra coverage - Fix 2: skip unreadable dirs (let Ok(entries) = read_dir) instead of propagating the error and aborting all skill discovery - Fix 3: update doc comment on format_skills_xml and inline category comment to include knowledge in the fixed order; extend is_excluded_dir doc with the user-visible tradeoff note - Fix 4: add workflow skill to T6 ordering test and assert wf < know Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
discover_skillsis now recursive — findsSKILL.mdat any depth (so knowledge docs underknowledge/<topic>/are picked up), skippingnode_modules/.git/docs/hidden dirs. A dir with aSKILL.mdis a leaf (not descended into). An unreadable subdir is skipped rather than aborting all discovery.format_skills_xmladdsknowledgeto the fixed category order, so knowledge entries group after the skill categories in the prompt.knowledge/and rides the existing sync to workers.Test Plan
cargo test --bin cica skills— 14 pass (incl. nested discovery + vendor-dir exclusion + category-ordering)cargo clippy --all-targets -- -D warnings— 0cargo fmt --check— cleanknowledge/entries appear grouped underknowledge; agent readsdata-model/glossarywhen answering data/domain questionsNote: nested
knowledge/entries are only discovered once this recursive-discovery change is released (deployed cica 0.9.2 scans top-level only). Top-level skills keep working throughout.🤖 Generated with Claude Code