TQ: Use BaseboardId instead of PlatformId #9121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PlatformId was used as an internal placeholder during trust quorum protocol development. In order to integrate the trust quorum protocol code into the rest of Omicron we need to use the proper `BaseboardId` type from `sled-agent-types`. The real `PlatformId` comes from the `dice-util-msgs` crate and we'll need to be able to compare that `PlatfromId` with `BaseboardId` and convert from `PlatformId` to `BaseboardId` in the future.
andrewjstone
requested review from
sunshowers and
plotnick
and removed request for
sunshowers
sunshowers
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlatformId was used as an internal placeholder during trust quorum protocol development. In order to integrate the trust quorum protocol code into the rest of Omicron we need to use the proper
BaseboardIdtype fromsled-agent-types. The realPlatformIdcomes from thedice-util-msgscrate and we'll need to be able to compare thatPlatfromIdwithBaseboardIdand convert fromPlatformIdtoBaseboardIdin the future.