[nexus] Pool -> PoolBuilder, make backtrace collection configurable #9074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
commented
Sep 24, 2025
| }; | ||
|
|
||
| let policy = policy.unwrap_or_else(|| Policy::default()); | ||
| let collect_backtraces = collect_backtraces.unwrap_or(true); |
There was a problem hiding this comment.
This is where we match the current behavior for backtrace collection by default: unless requested otherwise, collect_backtraces = true.
smklein
commented
Sep 24, 2025
| /// | ||
| /// Creating this pool does not necessarily wait for connections to become | ||
| /// available, as backends may shift over time. | ||
| pub fn new(log: &Logger, resolver: &QorbResolver) -> Self { |
There was a problem hiding this comment.
Since we already have three different constructors for a Pool...
- I didn't want to add an argument to all of them
- I didn't want to add a fourth constructor
So I switched to a builder pattern instead.
|
It's N = 1, but, observing the junit XML output for the ubuntu build-and-test (which is much more stable than the helios variant):
This supports your theory from #9064 (comment) - that the collection of backtraces on every collection had a non-negligible overhead across the whole test suite. This PR should still give us the benefits of collecting backtraces in production, but avoid the cost for our test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoolBuilderconstructor forPoolobjectscollect_backtracesoverride option during pool constructioncollect_backtraces = falsefor some testsFixes #9064