update cc crate
#8646
Merged
update cc crate
#8646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
most importantly this gets us rust-lang/cc-rs#1496 which fixes oxidecomputer/helios#192 -style miscompilation of neuxs (and several other binaries here). I suspect that for `clickhouse-admin-*`, `cockroach-admin`, and `dns-server` both errnos are present but the incorrect global `errno` goes unused - it's present through rustls/ring/aws-lc-rs/etc being compiled and linked in, but if TLS interfaces aren't used there (yet!) then it's not an issue (yet!). Nexus presents HTTPS though, so the `errno`-clobbery code is used there. Lets get that fixed.
sunshowers
approved these changes
Jul 20, 2025
hawkw
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
most importantly this gets us
rust-lang/cc-rs#1496 which fixes oxidecomputer/helios#192 -style miscompilation of neuxs (and several other binaries here).
While for
clickhouse-admin-*,cockroach-admin, anddns-serverboth errnos are present, I suspect the globalerrnogoes unused - it's present through rustls/ring/aws-lc-rs/etc being compiled and linked in, but if TLS interfaces aren't used there (yet!) then it's not an issue (yet!).Nexus presents HTTPS though, so the
errno-clobbery code is used there. Lets get that fixed.