Collect internal DNS generation in inventory #8643
Open
+268
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallagher
reviewed
Jul 21, 2025
There was a problem hiding this comment.
Can we also update the inventory display implementation? Should be easy now that #8613 has landed.
Comment on lines
+259
to
+262
| // TODO(https://github.com/oxidecomputer/omicron/issues/8602): | ||
| // If we could look up all DNS services, we could skip | ||
| // this port hard-coding. | ||
| addr.set_port(omicron_common::address::DNS_HTTP_PORT); |
There was a problem hiding this comment.
The DNS OmicronZoneType variants already do store two separate addresses; I think maybe we're already getting back DNS_HTTP_PORT here:
omicron/internal-dns/types/src/config.rs
Line 568 in f328b32
smklein
force-pushed
the
inventory-collect-timesync
branch
3 times, most recently
from
c16686f to
bea6e02
Compare
smklein
force-pushed
the
inventory-collect-dns
branch
from
a7dca86 to
e7f1843
Compare
smklein
force-pushed
the
inventory-collect-timesync
branch
from
bea6e02 to
5f2c4dd
Compare
smklein
force-pushed
the
inventory-collect-dns
branch
2 times, most recently
from
93db211 to
1fc3373
Compare
smklein
force-pushed
the
inventory-collect-dns
branch
from
1fc3373 to
9fda2da
Compare
Updated nexus/types/src/inventory/display.rs to include this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8544