-
Notifications
You must be signed in to change notification settings - Fork 45
reconfigurator-cli could let you set SP versions #8273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove now-superfluous `OrderedComponent` enum.
karencfv
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a small optional nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #8269.
This PR:
reconfigurator-cli
's internal model of sleds to include cabooses for the SP's active and inactive slotssled-show
inventory-generate
sled-update-sp
for setting the version in these caboose fieldsThe goal here is to work toward being able to demo/test the planner behavior around pending MGS updates. With this PR (and #8269, on which it's based), I was able to:
sled-update-sp
to set the inactive slot to something else, invalidating the configured updatereconfigurator-cli
about TUF artifacts, which it doesn't know about yet.)sled-update-sp
to set the active slot to the version we're trying to update toThere are some limitations here:
reconfigurator-cli
doesn't know about TUF artifacts. (This does work afterreconfigurator-cli
should support setting target release #8283.)