-
Notifications
You must be signed in to change notification settings - Fork 199
Read a few more gimlet sequencer regs in A1 #2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sample ringbuf output
Fixes #1195 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I know @Aaron-Hartwig has been messing here too so your two PRs may intersect slightly and he may want to also take a peek here as he's been trying to improve this stuff for better mfg debug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this! In general I've been trying to improve the ringbuf contents here as a step towards making debug easier. I think the best we can do now is log bytes (as this PR does), but in the future I'd like to be able to remove the need to have the register map pulled up to make sense of things. (see #2103)
No description provided.