Skip to content

Read a few more gimlet sequencer regs in A1 #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged

Read a few more gimlet sequencer regs in A1 #2106

merged 2 commits into from
Jun 24, 2025

Conversation

labbott
Copy link
Collaborator

@labbott labbott commented Jun 23, 2025

No description provided.

@labbott
Copy link
Collaborator Author

labbott commented Jun 23, 2025

Sample ringbuf output

 95  751        2        1 A1Status(0x3)
  96  758        2        1 A1Readbacks(0xf)
  97  765        2        1 A1OutStatus(0x1f)
  98  751        2        1 A1Status(0x3)
  99  758        2        1 A1Readbacks(0xf)
 100  765        2        1 A1OutStatus(0x1f)
 101  751        2        1 A1Status(0x3)
 102  758        2        1 A1Readbacks(0xf)
 103  765        2        1 A1OutStatus(0x1f)
 104  751        2        1 A1Status(0x3)
 105  758        2        1 A1Readbacks(0xf)
 106  765        2        1 A1OutStatus(0x1f)
 107  751        2        1 A1Status(0x3)
 108  758        2        1 A1Readbacks(0xf)
 109  765        2        1 A1OutStatus(0x1f)
 110  751        2        1 A1Status(0x3)
 111  758        2        1 A1Readbacks(0xf)
 112  765        2        1 A1OutStatus(0x1f)
 113  751        2        1 A1Status(0x3)
 114  758        2        1 A1Readbacks(0xf)
 115  765        2        1 A1OutStatus(0x1f)
 116  751        2        1 A1Status(0x3)
 117  758        2        1 A1Readbacks(0xf)
 118  765        2        1 A1OutStatus(0x1f)
 119  751        2        1 A1Status(0x3)
 120  758        2        1 A1Readbacks(0xf)
 121  765        2        1 A1OutStatus(0x1f)
 122  751        2        1 A1Status(0x3)
 123  758        2        1 A1Readbacks(0xf)
 124  765        2        1 A1OutStatus(0x1f)
 125  751        2        1 A1Status(0x3)
 126  758        2        1 A1Readbacks(0xf)
 127  765        2        1 A1OutStatus(0x1f)
   0  751        3        1 A1Status(0x3)
   1  758        3        1 A1Readbacks(0xf)
   2  765        3        1 A1OutStatus(0x1f)
   3  751        3        1 A1Status(0x3)
   4  758        3        1 A1Readbacks(0xf)
   5  765        3        1 A1OutStatus(0x1f)
   6  751        3        1 A1Status(0x3)
   7  758        3        1 A1Readbacks(0xf)
   8  765        3        1 A1OutStatus(0x1f)
   9  751        3        1 A1Status(0x3)
  10  758        3        1 A1Readbacks(0xf)
  11  765        3        1 A1OutStatus(0x1f)
  12  751        3        1 A1Status(0x3)
  13  758        3        1 A1Readbacks(0xf)
  14  765        3        1 A1OutStatus(0x1f)
  15  751        3        1 A1Status(0x3)
  16  758        3        1 A1Readbacks(0xf)
  17  765        3        1 A1OutStatus(0x1f)
  18  751        3        1 A1Status(0x3)
  19  758        3        1 A1Readbacks(0xf)
  20  765        3        1 A1OutStatus(0x1f)
  21  751        3        1 A1Status(0x3)
  22  758        3        1 A1Readbacks(0xf)
  23  765        3        1 A1OutStatus(0x1f)
  24  751        3        1 A1Status(0x3)
  25  758        3        1 A1Readbacks(0xf)
  26  765        3        1 A1OutStatus(0x1f)
  27  751        3        1 A1Status(0x3)
  28  758        3        1 A1Readbacks(0xf)
  29  765        3        1 A1OutStatus(0x1f)
  30  751        3        1 A1Status(0x3)
  31  758        3        1 A1Readbacks(0xf)
  32  765        3        1 A1OutStatus(0x1f)
  33  751        3        1 A1Status(0x3)
  34  758        3        1 A1Readbacks(0xf)
  35  765        3        1 A1OutStatus(0x1f)
  36  751        3        1 A1Status(0x3)
  37  758        3        1 A1Readbacks(0xf)
  38  765        3        1 A1OutStatus(0x1f)
  39  751        3        1 A1Status(0x3)
  40  758        3        1 A1Readbacks(0xf)
  41  765        3        1 A1OutStatus(0x1f)
  42  751        3        1 A1Status(0x3)
  43  758        3        1 A1Readbacks(0xf)
  44  765        3        1 A1OutStatus(0x1f)
  45  751        3        1 A1Status(0x3)
  46  758        3        1 A1Readbacks(0xf)
  47  765        3        1 A1OutStatus(0x1f)
  48  751        3        1 A1Status(0x3)
  49  758        3        1 A1Readbacks(0xf)
  50  765        3        1 A1OutStatus(0x1f)
  51  751        3        1 A1Status(0x3)
  52  758        3        1 A1Readbacks(0xf)
  53  765        3        1 A1OutStatus(0x1f)
  54  751        3        1 A1Status(0x3)
  55  758        3        1 A1Readbacks(0xf)
  56  765        3        1 A1OutStatus(0x1f)
  57  751        3        1 A1Status(0x3)
  58  758        3        1 A1Readbacks(0xf)
  59  765        3        1 A1OutStatus(0x1f)
  60  751        3        1 A1Status(0x3)
  61  758        3        1 A1Readbacks(0xf)
  62  765        3        1 A1OutStatus(0x1f)
  63  751        3        1 A1Status(0x3)
  64  758        3        1 A1Readbacks(0xf)
  65  765        3        1 A1OutStatus(0x1f)
  66  751        3        1 A1Status(0x3)
  67  758        3        1 A1Readbacks(0xf)
  68  765        3        1 A1OutStatus(0x1f)
  69  751        3        1 A1Status(0x3)
  70  758        3        1 A1Readbacks(0xf)
  71  765        3        1 A1OutStatus(0x1f)
  72  751        3        1 A1Status(0x5)
  73  758        3        1 A1Readbacks(0xf)
  74  765        3        1 A1OutStatus(0xf)
  75  783        3        1 CPUPresent(true)
  76  793        3        1 Coretype { coretype: true, sp3r1: true, sp3r2: false }

Fixes #1195

@labbott labbott requested a review from nathanaelhuffman June 23, 2025 17:50
Copy link
Contributor

@nathanaelhuffman nathanaelhuffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I know @Aaron-Hartwig has been messing here too so your two PRs may intersect slightly and he may want to also take a peek here as he's been trying to improve this stuff for better mfg debug.

Copy link
Contributor

@Aaron-Hartwig Aaron-Hartwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this! In general I've been trying to improve the ringbuf contents here as a step towards making debug easier. I think the best we can do now is log bytes (as this PR does), but in the future I'd like to be able to remove the need to have the register map pulled up to make sense of things. (see #2103)

@labbott labbott merged commit 3d3df17 into master Jun 24, 2025
135 checks passed
@labbott labbott deleted the read_a1_regs branch June 24, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants