Repository navigation
Refactor and clean up mode syntax - #108
Merged
Merged
Conversation
dvulakh
force-pushed
the
ocamlformat-align-at-atat
branch
from
May 1, 2025 20:53
9bb1c5d to
fcc42cf
Compare
riaqn
commented
May 6, 2025
Author
|
I've reviewed @dvulakh 's commits until "fix handling of parser edge-case" |
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
just needed to up the iterations in [opts] Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
dvulakh
force-pushed
the
ocamlformat-align-at-atat
branch
from
May 7, 2025 21:36
3197611 to
a93c0c7
Compare
Signed-off-by: David Vulakh <dvulakh@janestreet.com>
dvulakh
marked this pull request as ready for review
May 30, 2025 19:54
dvulakh
self-requested a review
May 30, 2025 19:55
dvulakh
approved these changes
May 30, 2025
dvulakh
left a comment
dvulakh
left a comment
There was a problem hiding this comment.
I'm happy to merge this in its current state. I haven't been able to figure out why the MacOS CI is broken, but am in favor of merging anyways and fixing later if we end up internally blocked on this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR imports the latest changes from the compiler, and does some clean-up:
parser.mlychanges from Refactor new mode syntax oxcaml#3522 is adapted to parser-extendedCurrently it has a few issues: