forked from ocaml-ppx/ocamlformat
-
Notifications
You must be signed in to change notification settings - Fork 15
Refactor and clean up mode syntax #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9bb1c5d
to
fcc42cf
Compare
riaqn
commented
May 6, 2025
I've reviewed @dvulakh 's commits until "fix handling of parser edge-case" |
Signed-off-by: David Vulakh <[email protected]>
Signed-off-by: David Vulakh <[email protected]>
Signed-off-by: David Vulakh <[email protected]>
just needed to up the iterations in [opts] Signed-off-by: David Vulakh <[email protected]>
Signed-off-by: David Vulakh <[email protected]>
Signed-off-by: David Vulakh <[email protected]>
Signed-off-by: David Vulakh <[email protected]>
Signed-off-by: David Vulakh <[email protected]>
Signed-off-by: David Vulakh <[email protected]>
Signed-off-by: David Vulakh <[email protected]>
Signed-off-by: David Vulakh <[email protected]>
Signed-off-by: David Vulakh <[email protected]>
Signed-off-by: David Vulakh <[email protected]>
Signed-off-by: David Vulakh <[email protected]>
3197611
to
a93c0c7
Compare
Signed-off-by: David Vulakh <[email protected]>
dvulakh
approved these changes
May 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to merge this in its current state. I haven't been able to figure out why the MacOS CI is broken, but am in favor of merging anyways and fixing later if we end up internally blocked on this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports the latest changes from the compiler, and does some clean-up:
parser.mly
changes from Refactor new mode syntax oxcaml#3522 is adapted to parser-extendedCurrently it has a few issues: