Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prettier): remove incorrect comment printing logic #5889

Merged

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Sep 19, 2024

Remove the previous incorrect implementation, cc @leaysgur

@Boshen Boshen changed the title chore(prettier): remove comment printing logic chore(prettier): remove incorrect comment printing logic Sep 19, 2024
@github-actions github-actions bot added the A-prettier Area - Prettier label Sep 19, 2024
Copy link

graphite-app bot commented Sep 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codspeed-hq bot commented Sep 19, 2024

CodSpeed Performance Report

Merging #5889 will not alter performance

Comparing 09-19-chore_prettier_remove_comment_printing_logic (12d4888) with main (a23879c)

Summary

✅ 29 untouched benchmarks

@Boshen Boshen force-pushed the 09-19-chore_prettier_remove_comment_printing_logic branch from 781db16 to b49ca0c Compare September 19, 2024 15:15
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 20, 2024
Copy link

graphite-app bot commented Sep 20, 2024

Merge activity

  • Sep 19, 10:41 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 19, 10:41 PM EDT: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Sep 19, 10:41 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 20, 1:25 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Sep 20, 1:26 AM EDT: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Sep 21, 12:44 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 21, 12:44 AM EDT: Boshen added this pull request to the Graphite merge queue.
  • Sep 21, 12:48 AM EDT: Boshen merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Sep 20, 2024
@Boshen Boshen force-pushed the 09-19-chore_prettier_remove_comment_printing_logic branch from b49ca0c to ef940c3 Compare September 21, 2024 04:18
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Sep 21, 2024
Remove the previous incorrect implementation, cc @leaysgur
@Boshen Boshen force-pushed the 09-19-chore_prettier_remove_comment_printing_logic branch from ef940c3 to 12d4888 Compare September 21, 2024 04:45
@graphite-app graphite-app bot merged commit 12d4888 into main Sep 21, 2024
25 checks passed
@graphite-app graphite-app bot deleted the 09-19-chore_prettier_remove_comment_printing_logic branch September 21, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-prettier Area - Prettier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant