Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions crates/oxc_linter/src/rules/eslint/no_unused_vars/tests/oxc.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1202,6 +1202,30 @@ fn test_type_references() {
.test_and_snapshot();
}

#[test]
fn test_ts_in_assignment() {
let pass = vec![
r"export const onClick = (value, key) => {
const obj: Record<string, string> = {};
(obj[key] as any) = value;
}",
r"export const onClick = (value, key) => {
const obj: Record<string, string> = {};
(obj[key] satisfies any) = value;
}",
r"export const onClick = (value, key) => {
const obj: Record<string, string> = {};
(obj[key]!) = value;
}",
];
let fail = vec![];

Tester::new(NoUnusedVars::NAME, NoUnusedVars::PLUGIN, pass, fail)
.intentionally_allow_no_fix_tests()
.with_snapshot_suffix("oxc-assignment-ts")
.test();
}

// #[test]
// fn test_template() {
// let pass = vec![];
Expand Down
21 changes: 21 additions & 0 deletions crates/oxc_linter/src/rules/eslint/no_unused_vars/usage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,27 @@ impl<'a> Symbol<'_, 'a> {
return false; // we can short-circuit
}
}
AssignmentTarget::TSAsExpression(v)
if v.expression.is_member_expression() =>
{
return false;
}
AssignmentTarget::TSSatisfiesExpression(v)
if v.expression.is_member_expression() =>
{
return false;
}
AssignmentTarget::TSNonNullExpression(v)
if v.expression.is_member_expression() =>
{
return false;
}
AssignmentTarget::TSTypeAssertion(v)
if v.expression.is_member_expression() =>
{
return false;
}

// variable is being used to index another variable, this is
// always a usage
// todo: check self index?
Expand Down
Loading