[tests-only][full-ci] add test to list drives by federation user #10753
+78
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashant-gurung899
force-pushed
the
tests-ocm-list-shares
branch
from
6f3b7ad to
3f18f02
Compare
30 tasks
prashant-gurung899
force-pushed
the
tests-ocm-list-shares
branch
from
3f18f02 to
62df3fb
Compare
prashant-gurung899
requested review from
anon-pradip,
saw-jan,
amrita-shrestha,
nabim777,
S-Panta,
PrajwolAmatya and
nirajacharya2
prashant-gurung899
force-pushed
the
tests-ocm-list-shares
branch
2 times, most recently
from
c41a2dc to
dae200d
Compare
Signed-off-by: prashant-gurung899 <[email protected]>
prashant-gurung899
force-pushed
the
tests-ocm-list-shares
branch
from
dae200d to
133e17c
Compare
|
| And using server "REMOTE" | ||
| When user "Brian" lists all available spaces via the Graph API | ||
| Then the HTTP status code should be "200" | ||
| And the JSON response should contain space called "Brian Murphy" and match |
There was a problem hiding this comment.
Suggested change
| And the JSON response should contain space called "Brian Murphy" and match | |
| And the JSON response should contain space called "Shares" owned by "Brian" and match |
I think we need to check for the Shares space instead of Brian's personal space, as the shared resources are available in Shares space.
There was a problem hiding this comment.
we do not have to check the personal space. We can just check that the shares doesn't exist in the list
ocm shares should not be listed in the drives list
saw-jan
reviewed
Dec 12, 2024
| @@ -1229,3 +1229,81 @@ Feature: an user shares resources using ScienceMesh application | |||
| } | |||
| } | |||
| """ | |||
|
|
|||
| @issue-10689 | |||
| Scenario: federation user lists ocm shares | |||
There was a problem hiding this comment.
the scenario title is a bit off from the action
Suggested change
| Scenario: federation user lists ocm shares | |
| Scenario: federation user lists all the spaces |
saw-jan
reviewed
Dec 12, 2024
| And using server "REMOTE" | ||
| When user "Brian" lists all available spaces via the Graph API | ||
| Then the HTTP status code should be "200" | ||
| And the JSON response should contain space called "Brian Murphy" and match |
There was a problem hiding this comment.
we do not have to check the personal space. We can just check that the shares doesn't exist in the list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds test to list the drives by federation user and check that federation shares doesn't get listed.
See: #10689 (comment)
Related Issue
nameandroot.remoteItemvalues in the drives list #10689Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: