[tests-only][full-ci] Tests for checking share access after changing share role to and from "Denied" #10703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
This PR is subsequent to the PR: #10696. So waiting for that to be merged. |
anon-pradip
force-pushed
the
test/change-share-role-Denied-to-and-fro
branch
3 times, most recently
from
32dd530 to
49fb121
Compare
|
Making it |
anon-pradip
requested review from
saw-jan,
prashant-gurung899,
Salipa-Gurung,
amrita-shrestha,
S-Panta and
PrajwolAmatya
anon-pradip
commented
Dec 18, 2024
anon-pradip
requested review from
ishabaral,
SagarGi,
nabim777 and
nirajacharya2
anon-pradip
force-pushed
the
test/change-share-role-Denied-to-and-fro
branch
from
49fb121 to
8c29bf5
Compare
anon-pradip
force-pushed
the
test/change-share-role-Denied-to-and-fro
branch
from
8c29bf5 to
fa9e8d4
Compare
anon-pradip
changed the title
9 tasks
anon-pradip
force-pushed
the
test/change-share-role-Denied-to-and-fro
branch
from
fa9e8d4 to
8f61c83
Compare
anon-pradip
force-pushed
the
test/change-share-role-Denied-to-and-fro
branch
from
8f61c83 to
ce9b6e0
Compare
saw-jan
reviewed
Dec 23, 2024
anon-pradip
force-pushed
the
test/change-share-role-Denied-to-and-fro
branch
2 times, most recently
from
269a596 to
cebac7c
Compare
anon-pradip
force-pushed
the
test/change-share-role-Denied-to-and-fro
branch
from
cebac7c to
3776d19
Compare
anon-pradip
force-pushed
the
test/change-share-role-Denied-to-and-fro
branch
from
3776d19 to
2ab353e
Compare
|
Is there a need to test for the public link or not? Other LGTM 👍 |
amrita-shrestha
requested changes
Dec 27, 2024
anon-pradip
force-pushed
the
test/change-share-role-Denied-to-and-fro
branch
3 times, most recently
from
e11e6b3 to
d6889ba
Compare
anon-pradip
force-pushed
the
test/change-share-role-Denied-to-and-fro
branch
2 times, most recently
from
7b17814 to
0ce0f54
Compare
anon-pradip
force-pushed
the
test/change-share-role-Denied-to-and-fro
branch
from
0ce0f54 to
5383e55
Compare
|
saw-jan
approved these changes
Dec 31, 2024
good point, added it to the list to check if it's possible
|
amrita-shrestha
approved these changes
Jan 1, 2025
ownclouders
pushed a commit
that referenced
this pull request
Jan 1, 2025
…-to-and-fro [tests-only][full-ci] Tests for checking share access after changing share role to and from "Denied"
ownclouders
pushed a commit
that referenced
this pull request
Jan 2, 2025
…-to-and-fro [tests-only][full-ci] Tests for checking share access after changing share role to and from "Denied"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
$spaceNamevariable properly inside the functionuserShouldOrShouldNotBeAbleToDownloadFileFromSpacewhich was unused (was just placed in the params list) previously.Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: