[tests-only][full-ci] add tests to remove access of shared resource to federated user #10672
+54
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
prashant-gurung899
force-pushed
the
tests-ocm-delete-share
branch
2 times, most recently
from
f9f042c to
7e37e5a
Compare
prashant-gurung899
requested review from
anon-pradip,
saw-jan,
amrita-shrestha,
S-Panta,
PrajwolAmatya and
nirajacharya2
saw-jan
reviewed
Nov 28, 2024
prashant-gurung899
force-pushed
the
tests-ocm-delete-share
branch
4 times, most recently
from
e3266d0 to
7ba257a
Compare
saw-jan
reviewed
Nov 28, 2024
prashant-gurung899
force-pushed
the
tests-ocm-delete-share
branch
from
7ba257a to
7135198
Compare
|
This PR is on hold because of bug; #10689 |
|
Moving it back to |
prashant-gurung899
force-pushed
the
tests-ocm-delete-share
branch
2 times, most recently
from
9474779 to
208932e
Compare
saw-jan
reviewed
Dec 11, 2024
Signed-off-by: prashant-gurung899 <[email protected]>
prashant-gurung899
force-pushed
the
tests-ocm-delete-share
branch
from
208932e to
a28947f
Compare
|
S-Panta
reviewed
Dec 12, 2024
| * | ||
| * @return void | ||
| */ | ||
| public function userShouldHaveFederatedShareSharedByUserFromSpace(string $sharee, string $shouldOrNot, string $share, string $sharer, string $space): void { |
There was a problem hiding this comment.
Suggested change
| public function userShouldHaveFederatedShareSharedByUserFromSpace(string $sharee, string $shouldOrNot, string $share, string $sharer, string $space): void { | |
| public function userShouldOrShouldNotHaveFederatedShareSharedByUserFromSpace(string $sharee, string $shouldOrNot, string $share, string $sharer, string $space): void { |
Just my suggestion
saw-jan
reviewed
Dec 12, 2024
| @@ -1738,36 +1738,39 @@ public function userRemovesTheLastLinkShareOfSpaceUsingPermissionsEndpointOfGrap | |||
| * @param string $sharer | |||
| * @param string $space | |||
| * @param bool $shouldExist | |||
| * @param bool|null $federatedSHare | |||
There was a problem hiding this comment.
Suggested change
| * @param bool|null $federatedSHare | |
| * @param bool $federatedSHare |
| * | ||
| * @return void | ||
| * @throws GuzzleException | ||
| * @throws JsonException | ||
| * @throws Exception | ||
| */ | ||
| public function checkIfShareExists(string $share, string $sharee, string $sharer, string $space, bool $shouldExist = true): void { | ||
| public function checkIfShareExists(string $share, string $sharee, string $sharer, string $space, bool $shouldExist = true, ?bool $federatedSHare= false): void { |
There was a problem hiding this comment.
Suggested change
| public function checkIfShareExists(string $share, string $sharee, string $sharer, string $space, bool $shouldExist = true, ?bool $federatedSHare= false): void { | |
| public function checkIfShareExists(string $share, string $sharee, string $sharer, string $space, bool $shouldExist = true, bool $federatedShare = false): void { |
| @@ -1229,3 +1229,24 @@ Feature: an user shares resources using ScienceMesh application | |||
| } | |||
| } | |||
| """ | |||
|
|
|||
| @issue-10213 | |||
| Scenario: local user deletes access of shared resource to federated user | |||
There was a problem hiding this comment.
Suggested change
| Scenario: local user deletes access of shared resource to federated user | |
| Scenario: local user removes access of federated user from a resource |
Comment on lines
+1250
to
+1252
| And user "Brian" lists the shares shared with him without retry using the Graph API | ||
| Then the HTTP status code should be "200" | ||
| And user "Brian" should not have a federated share "FOLDER" shared by user "Alice" from space "Personal" |
There was a problem hiding this comment.
Suggested change
| And user "Brian" lists the shares shared with him without retry using the Graph API | |
| Then the HTTP status code should be "200" | |
| And user "Brian" should not have a federated share "FOLDER" shared by user "Alice" from space "Personal" | |
| Then user "Brian" should not have a federated share "FOLDER" shared by user "Alice" from space "Personal" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests to remove access of a shared resource to federated user( both local and remote).
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: