[feature/sharing-ng] Support for new ocis spaces/sharing capabilities #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-schwarz
force-pushed
the
feature/sharing-ng
branch
3 times, most recently
from
414ecdc to
7b30f10
Compare
felix-schwarz
force-pushed
the
feature/sharing-ng
branch
from
e1ed8ff to
7f3503b
Compare
- AppRootViewController: add support for passing arbitrary objects into moreOptions() - ManageSpaceAction, DetailsSpaceAction: new actions to edit and show details of spaces - DisableSpaceAction: new action to disable a space - MembersSpaceAction: new action to manage members and links of a space - AccountControllerSpacesGridViewController: add button to create a new space - OCItem+UniversalItemListCellContentProvider: add support for drive name titles - OCShare+UniversalItemListCellContentProvider: add deeper support for OCShareRoles to closer resemble ownCloud Web - UniversalItemListCell: add new utility method to create a token-style SegmentViewItem - ClientContext: add property to pass along sharing roles - ShareViewController: add support for ocis-style roles and OCShare.sharePermissions - SharingViewController: use different title strings if item is a drive root - SpaceManagementViewController: new view controller to create and manage spaces - UIView+ThemeCSS: add withPadding() method - ThemeCSSTextField+Styled: new initializer to create form text fields - SDK update
- ShareViewController: fix: if removing the password and resetting it, the password is actually set anew - and not attempted to be removed
…ate for non-link shares on ocis servers
- remove .drives instance variable and replace it with an convenience accessor returning the OCDrive for single item ActionContexts if the OCItem is the root item of a drive - remove obj parameter - *SpaceAction: use Action/ActionContext changes to simplify implementation - soft-remove DetailsSpaceAction as it is likely to become obsolete - OCItem+UniversalItemListCellContentProvider: show quota information as detail for drive root items - SpaceManagementViewController: code cleanup; remove owner and permissions section - OCItem+Extension: add .driveQuotaLocalized() method
- ByteCountUnit: class for byte count unit conversion, localized number formatting and parsing - SpaceManagementViewController: - add support for setting a quota when creating a new space - add support for change or remove the quota of an existing space - String+Extension: add convenience accessor to determine if a string consists purely of numeric characters
…lText "User" if userName is not available to avoid empty gaps in cells when listing users in the UI - update SDK
…r in the SpaceManagementViewController - SpaceManagementViewController: add new "Actions" section with actions matching in the .spaceAction location - *SpaceAction: add permission checks for drives - bring back DetailsSpaceAction to bring up a special read-only version of SpaceManagementViewController (implementation pending) - OCShare+UniversalItemListCellContentProvide: improve compilation of detailSegments to allow any combination of items - SharingViewController: - add support for create/update permission and dynamically adapt the UI accordingly - implement live update to change the UI as permissions change on the server side - update SDK
- SpaceManagementViewController: implement .details Mode by disabling input fields
…ilText for OCUsers without userName - SDK update
- factor out ClientContext/UI code for various space actions to be called from different places - use OCCore rather than OCConnection APIs - DisableSpaceAction: factor out action code to OCDrive+ManagementActions - AccountControllerSpacesGridViewController: - replace "+" button with "..." button offering - Create Space - Show/Hide disabled spaces - factor out space creation code to OCDrive+ManagementActions - DriveGridCell: - add support for disabledLabel - add support for moreMenu and disabled properties - DriveListCell: add support for context menu offering restore/delete space actions - SpaceManagementViewController: switch from direct OCConnection to OCCore APIs - update SDK to gain bug fixes and OCCore space management APIs
- AccountControllerSpacesGridViewController: determine canManageSpaces based on logged in user's permissions - OCDrive+ManagementActions: add alert asking user for confirmation before deleting a space
…poraryUploadURL - EditSpaceDescriptionAction: new action to edit the markdown description of a space - MarkdownViewController: new view controller to display and edit markdown content - SpaceManagementViewController: add support for space templates upon creation - OCResourceText+ViewProvider: code syntax modernization
felix-schwarz
force-pushed
the
feature/sharing-ng
branch
from
ec552a6 to
daf74fc
Compare
…otoAlbumTable* and PhotoSelectionView* classes from project - EditSpaceDescriptionAction: add importByCopying option, minor code improvements - EditSpaceImageAction: add new action to set a space image from - a photo - a text/emoji - AI generated by Image Playground (untested at this point)
…MDM enable/disable of AI features - EditSpaceImageAction: gate access to Image Playground via endorServices.shared.allowAIFeatures
…dency, trying to fix CI build issue
Include Xcode version 16.2
(1)Software keyboard overlaps with the ScreenRecording_03-26-2025.15-10-12_1.MP4iPhone XR iOS18.2 |
(2)
Current: 3-dot-button on the top-right corner is missing Expected: 3-dot-button on the top-right corner available iPhone XR iOS18.2 |
|
@jesmrec I fixed (1) and (2) with the latest commits. Please have another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
App support for new spaces and sharing APIs.
Screenshots
Related Issue
#1421
#1422
SDK portion: owncloud/ios-sdk#135
Implementation progress
Prio 1
Prio 2
Duplicate Space--> needs proper server-side API (currently would need client to create space and copy contents over)Prio 3
Show Activities--> outside scope of this PR, feature of its ownTypes of changes
QA
Test Plan:
Reports:
Createbutton [feature/sharing-ng] Support for new ocis spaces/sharing capabilities #1435 (comment)