feat: emit current folder and fix update type #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
reviewed
Jun 25, 2021
LukasHirt
force-pushed
the
feat/different-update-events
branch
from
fe13cc5 to
76d6e4f
Compare
|
As it was only a change of one word I did a rebase. It shouldn't make the review harder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading new folder in Location picker, we are emitting an "update" with the current route as an argument. We've fixed that the argument has type array now so that it is consistent with all other arguments returned in the
updateevent. We've also added event calledfolderLoadedthat is emitted every time a loading of any folder has ended.It is emitting the current folder as an argument.
Fixes #71