-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Select current folder" not possible with hidden Select button #71
Comments
IMO the |
It works now, but the API is a bit inconsistent: the Luckily that was necessary. Otherwise there is no way to detect when a subfolder was selected via navigation or via selection. This is used to determine the text of the select button (whether to add the word "current" or not). So either the API documentation should be updated to reflect the different argument types, or the consumer needs some other way to distinguish whether the user will select the current folder or a selected subfolder. |
cc @LukasHirt |
When using external buttons to confirm the selection, the consumer of the file picker widget relies on
update
events to track the current selection. Inlocation
mode, the event fired after entering a new folder does not include any entries. This makes it impossible to select the current folder, like the internal button allows to.To solve this, either a separate event for navigation is required, or the
update
event inlocation
mode needs to include the current folder when nothing else is selected.Also, when issue #8 is implemented, the navigation/update event will need to be fired on initial load to communicate the actual permissions of the starting folder, i.e. whether the user is allowed to upload files there. If the root folder can have restricted permissions, then an initial event is already required now.
The text was updated successfully, but these errors were encountered: