Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Add acceptance tests to verify mount configurations using the occ command #36806

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Jan 22, 2020

Description

Add acceptance tests to verify mount configurations using the occ command

Related Issue

Related to #36704

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #36806 into master will decrease coverage by 0.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36806      +/-   ##
============================================
- Coverage     64.68%   64.42%   -0.26%     
  Complexity    19114    19114              
============================================
  Files          1269     1269              
  Lines         74801    74801              
  Branches       1327     1327              
============================================
- Hits          48383    48189     -194     
- Misses        26027    26221     +194     
  Partials        391      391
Flag Coverage Δ Complexity Δ
#javascript 54.1% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.57% <ø> (-0.29%) 19114 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/DB/AdapterOCI8.php 0% <0%> (-86.67%) 4% <0%> (ø)
...Builder/ExpressionBuilder/OCIExpressionBuilder.php 0% <0%> (-85.19%) 18% <0%> (ø)
lib/private/DB/OracleMigrator.php 0% <0%> (-76.85%) 10% <0%> (ø)
lib/private/DB/OracleConnection.php 0% <0%> (-66.67%) 12% <0%> (ø)
lib/private/DB/ConnectionFactory.php 83.56% <0%> (-6.85%) 22% <0%> (ø)
lib/private/DB/Adapter.php 82.71% <0%> (-6.18%) 25% <0%> (ø)
lib/private/Repair/RepairMismatchFileCachePath.php 94.55% <0%> (-3.51%) 51% <0%> (ø)
lib/private/Repair/RepairInvalidShares.php 97.26% <0%> (-2.74%) 17% <0%> (ø)
lib/private/AllConfig.php 93.83% <0%> (-2.06%) 43% <0%> (ø)
lib/private/Files/Cache/Cache.php 95.75% <0%> (-1.82%) 104% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99fcb49...978f5df. Read the comment docs.

@jasson99 jasson99 force-pushed the verifyMountConfiguration branch 2 times, most recently from 9b8d37d to 58663e0 Compare January 24, 2020 04:53
@jasson99 jasson99 force-pushed the verifyMountConfiguration branch 2 times, most recently from f700ec3 to be84905 Compare January 24, 2020 09:39
@jasson99 jasson99 force-pushed the verifyMountConfiguration branch from be84905 to 978f5df Compare January 24, 2020 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants