Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-only] Add acceptance test to delete local storage using occ command #36756

Merged
merged 1 commit into from
Jan 20, 2020
Merged

[Tests-only] Add acceptance test to delete local storage using occ command #36756

merged 1 commit into from
Jan 20, 2020

Conversation

jasson99
Copy link
Contributor

@jasson99 jasson99 commented Jan 14, 2020 •
edited
Loading

Description

Add acceptance test to delete local storage using occ command

Related Issue

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jasson99 jasson99 requested a review from dpakach January 14, 2020 09:22
@jasson99 jasson99 self-assigned this Jan 14, 2020
@codecov
Copy link

codecov bot commented Jan 14, 2020 •
edited
Loading

Codecov Report

Merging #36756 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36756   +/-   ##
=========================================
  Coverage     64.68%   64.68%           
  Complexity    19120    19120           
=========================================
  Files          1269     1269           
  Lines         74778    74778           
  Branches       1320     1320           
=========================================
  Hits          48372    48372           
  Misses        26018    26018           
  Partials        388      388
Flag Coverage Δ Complexity Δ
#javascript 54.12% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.85% <ø> (ø) 19120 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd0839b...510acd8. Read the comment docs.

@owncloud owncloud deleted a comment from update-docs bot Jan 16, 2020
@phil-davis phil-davis changed the title Add acceptance test to delete local storage using occ command [Tests-only] Add acceptance test to delete local storage using occ command Jan 16, 2020
phil-davis
phil-davis reviewed Jan 17, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and please rebase - that should remove the old createLocalStorage commits from the list in this PR

@haribhandari07 haribhandari07 merged commit 7cd5475 into master Jan 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the deleteLocalStorage branch January 20, 2020 03:54
@phil-davis phil-davis mentioned this pull request Feb 25, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpakach dpakach dpakach left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

Assignees

@jasson99 jasson99

Labels
4 - To release dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasson99 @phil-davis @dpakach @kiranparajuli589 @haribhandari07