Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify GH templates #4310

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Modify GH templates #4310

merged 1 commit into from
Feb 14, 2024

Conversation

jesmrec
Copy link
Collaborator

@jesmrec jesmrec commented Feb 12, 2024 •
edited
Loading

Changes:

  • In features template, new entry to add feature to release notes. So, it could be translated with more time in advance.
  • In release template, new task to check if new screenshots are required to be generated before/during QA phase to be ready in deployment time.
  • Add a new task to the release template: move the latest tag to the new release commit
  • Replace GitFlow for OneFlow in CONTRIBUTING.md file
  • Remove references to stable in release template

Related Issues

App:

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

JuancaG05
JuancaG05 requested changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions here, let me know what do you think @jesmrec 👍

@jesmrec jesmrec force-pushed the fix/some_fixes_in_gh_templates branch from 3d17e07 to 0711997 Compare February 12, 2024 11:08
@jesmrec jesmrec force-pushed the fix/some_fixes_in_gh_templates branch from 0711997 to da413e2 Compare February 13, 2024 12:05
@jesmrec jesmrec requested review from JuancaG05 and Aitorbp February 13, 2024 12:06
@jesmrec jesmrec force-pushed the fix/some_fixes_in_gh_templates branch from da413e2 to a1d2252 Compare February 13, 2024 12:08
JuancaG05
JuancaG05 reviewed Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny correction and a comment, give me your insight about it @jesmrec 😁

@jesmrec jesmrec force-pushed the fix/some_fixes_in_gh_templates branch 2 times, most recently from f55ab4f to 3084b91 Compare February 14, 2024 16:47
JuancaG05
JuancaG05 approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! I like it 💯

@jesmrec
modify GH templates adding two tasks: in features, add entry to relea…
b97f851 
…se notes. In release, generate screenshots before/during QA phase. Add a task in release for adding latest tag. Replace GitFlow for OneFlow in docs.
@jesmrec jesmrec force-pushed the fix/some_fixes_in_gh_templates branch from 3084b91 to b97f851 Compare February 14, 2024 17:09
@jesmrec jesmrec merged commit a329d23 into master Feb 14, 2024
5 checks passed
@jesmrec jesmrec deleted the fix/some_fixes_in_gh_templates branch February 14, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

@Aitorbp Aitorbp Awaiting requested review from Aitorbp

Assignees

@jesmrec jesmrec

Labels
Estimation - 1 (XS)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesmrec @JuancaG05