Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Add placeholder icon for .docxf files #4297

Merged
merged 4 commits into from
Feb 2, 2024
Merged

[FEATURE REQUEST] Add placeholder icon for .docxf files #4297

merged 4 commits into from
Feb 2, 2024

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Jan 26, 2024 •
edited
Loading

Related Issues

App:#4267

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@Aitorbp Aitorbp self-assigned this Jan 26, 2024
@Aitorbp Aitorbp linked an issue Jan 26, 2024 that may be closed by this pull request
[FEATURE REQUEST] Add placeholder icon for .docxf files #4267
Closed
7 tasks
@Aitorbp Aitorbp requested a review from JuancaG05 January 26, 2024 09:23
@JuancaG05 JuancaG05 changed the title [FEATURE REQUEST] Add placeholder icon for docxf files [FEATURE REQUEST] Add placeholder icon for .docxf files Jan 29, 2024
JuancaG05
JuancaG05 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 29, 2024

(1)

Icon should be used in the FAB creation option:

Screenshot 2024-01-29 at 13 16 10

Pixel 2 Android 11
4a7af1732

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 29, 2024

Not appliable to oC10 servers since they return as mimetype:

<d:getcontenttype>application/octet-stream</d:getcontenttype>

instead of

<d:getcontenttype>application/vnd.openxmlformats-officedocument.wordprocessingml.form</d:getcontenttype>

so, only for oCIS servers which returns the proper mimetype

@Aitorbp
Copy link
Contributor Author

Aitorbp commented Jan 30, 2024

(1)

Icon should be used in the FAB creation option:

Screenshot 2024-01-29 at 13 16 10

Pixel 2 Android 11 4a7af1732

Could you check again, please?

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 30, 2024

All right! approved

@Aitorbp Aitorbp force-pushed the fix/add_placeholder_icon_for_docxf_files branch 2 times, most recently from a0bc559 to 72125b0 Compare January 30, 2024 11:07
JuancaG05
JuancaG05 approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not the best solution as you said, but until we migrate every icon to vector this is more than acceptable 😄

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 1, 2024

Blocked till proper test instance is back

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 2, 2024

Basic checks performed, everything OK

@Aitorbp Aitorbp force-pushed the fix/add_placeholder_icon_for_docxf_files branch from 629d314 to f06d471 Compare February 2, 2024 07:49
@Aitorbp Aitorbp merged commit 3eced78 into master Feb 2, 2024
5 checks passed
@Aitorbp Aitorbp deleted the fix/add_placeholder_icon_for_docxf_files branch February 2, 2024 08:04
Aitorbp added a commit that referenced this pull request Feb 5, 2024
@Aitorbp
Merge pull request #4297 from owncloud/fix/add_placeholder_icon_for_d…
0ed6f23 
…ocxf_files

[FEATURE REQUEST] Add placeholder icon for .docxf files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@Aitorbp Aitorbp

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add placeholder icon for .docxf files
3 participants
@Aitorbp @jesmrec @JuancaG05