🎉 Automatic alt text for cloudflare images #4261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesau
commented
Dec 6, 2024
| border: 1px solid #ccc; | ||
| width: 100%; | ||
| &.ImageIndexPage__alt-text-editor--should-autosize { | ||
| field-sizing: content; |
There was a problem hiding this comment.
This is only supported in chrome as of now, but I think that's the browser most of the authors use.
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-12-06 00:13:41 UTC |
rakyi
approved these changes
Dec 6, 2024
| console.error( | ||
| `Error fetching GPT alt text for image ${imageId}`, | ||
| error | ||
| ) |
There was a problem hiding this comment.
Out of scope of this PR, but it's unfortunate if we currently have to effectively log the error twice to surface/log it properly. This shouldn't be necessary, in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
automatic.alt.text.mp4
Changes: