Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: persist query params when saving narrative view #4260

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Dec 5, 2024

This is just persisting them, we're not currently doing anything with this info. That's yet to come.

Part of #4128.

@owidbot
Copy link
Contributor

owidbot commented Dec 5, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-narrative-views-persist-query-params

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-12-05 17:44:52 UTC
Execution time: 1.42 seconds

Copy link
Contributor

@danyx23 danyx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@marcelgerber marcelgerber merged commit 4e3bf99 into master Dec 10, 2024
28 checks passed
@marcelgerber marcelgerber deleted the narrative-views-persist-query-params branch December 10, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants