refactor(admin): move admin inheritance tab to refs tab #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-12-04 17:32:24 UTC |
marcelgerber
force-pushed
the
inheritance-refs-tab
branch
from
a1e6267 to
395bb4c
Compare
sophiamersmann
approved these changes
Dec 5, 2024
marcelgerber
force-pushed
the
grapher-query-params
branch
from
2e6bdd6 to
549eaec
Compare
marcelgerber
force-pushed
the
inheritance-refs-tab
branch
from
395bb4c to
5086474
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the existing "Inheritance" tab functionality of the indicator chart editor into the existing "Refs" tab, and thereby gets rid of the Inheritance tab.
Its content is unchanged.
I also wanted to get the number behind the Refs label to work (e.g.
Refs (2)), but that was a bigger reshuffle than I anticipated. But it works now.