Add donors component #4251
Merged
Add donors component #4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-12-04 14:03:29 UTC |
rakyi
commented
Dec 4, 2024
| export class CreateDonors1733228214376 implements MigrationInterface { | ||
| public async up(queryRunner: QueryRunner): Promise<void> { | ||
| await queryRunner.query(`-- sql | ||
| CREATE TABLE donors ( |
There was a problem hiding this comment.
This table will be read and written to from the scripts that we use to update the donor list. Previously the scripts generated HTML, now they will use this table. That part will be reviewed and QA'd by Lars.
rakyi
commented
Dec 4, 2024
| ), | ||
| // TODO: better validation here? | ||
| () => GdocPost.create({ ...(json as any) }) | ||
| ) | ||
| .with( | ||
| OwidGdocType.AboutPage, | ||
| // TODO: better validation here? |
There was a problem hiding this comment.
Added the same TODO as above and below for consistency.
|
You can see the new list of donors here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also fixed a few unrelated things.