Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 disaggregate site-baker bugsnag errors #4049

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Oct 9, 2024

Bugsnag is currently grouping all errors occurring during baking as of #4005 being merged.

https://app.bugsnag.com/our-world-in-data/grapher-admin/errors/66d0c35a0ab81c7871ff95d5?filters[event.since]=30d&filters[error.status]=ignored

This PR allows us to set a custom groupingHash which overrides Bugsnag's default grouping heuristic. I've set it for gdocs baking on the specific error message so that all instances of e.g. Author "Our World in Data team" does not exist or is not published get grouped and can be ignored permanently, but Author "Mxa Rsero" does not exist or is not published would still get logged.

@ikesau ikesau requested a review from marcelgerber October 9, 2024 17:46
@ikesau ikesau self-assigned this Oct 9, 2024
@owidbot
Copy link
Contributor

owidbot commented Oct 9, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-disaggregate-bugsnag-site-baker-logs

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-10-09 18:04:04 UTC
Execution time: 1.23 seconds

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a nice way to solve this, let's go! 🚀

@ikesau ikesau merged commit 3f60f8b into master Oct 11, 2024
28 checks passed
@ikesau ikesau deleted the disaggregate-bugsnag-site-baker-logs branch October 11, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants