Add a way of marking articles as deprecated

[rakyi]

No description provided.

[owidbot]

Quick links (staging server):

Site	Admin	Wizard

Login: ssh owid@staging-site-deprecated-articles

• Site-screenshots: https://github.com/owid/site-screenshots/compare/deprecated-articles
• SVG tester: https://github.com/owid/owid-grapher-svgs/compare/deprecated-articles

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-08-30 10:22:40 UTC
Execution time: 1.18 seconds

[rakyi]

This is ready for review, but there is a chance the design will change slightly.

[ikesau]

Looks good overall! Just a few code nitpicks really.

Do you know if we still want to index deprecated articles and show them in the sitemap?

[ikesau]

Hey @rakyi sorry I went ahead and yak-shaved on your work without your blessing, but I realized earlier today in the cursor demo that my suggestion of using 0 | 1 still felt a bit code-smelly to me, so I investigated turning it into a boolean instead which MySQL can't do, and well, one thing led to another 😓

The only truly critical fix I made was in GdocFactory where I noticed a leading slash was there where it shouldn't be, which is what made me realize we should be using constants for these 2 filenames.

If you'd prefer, you can revert my changes (though you'll need to fix the leading slash again) and I'll add the constants in a separate PR.

Also, do we want to exclude archived posts from the sitemap and search index? 🙂

[rakyi]

Thank you for the changes!

Also, do we want to exclude archived posts from the sitemap and search index? 🙂

I forgot to reply to this before. We shouldn't exclude these posts from search and sitemap.

[ikesau]

Once you merge this, don't forget to add an example to the article documentation gdoc 🙂

You'll probably have to write it in the body and escape it so that ts-pattern doesn't complain - otherwise the docs themselves will have the deprecation notice which we probably don't want.

[rakyi]

Yeah, I was meaning to do that. Thank you for the tip!