🔨 incorporate PR feedback

owid · Dec 13, 2024 · 7774757 · 7774757
1 parent d220dd9
commit 7774757
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/adminSiteClient/ChartIndexPage.tsx b/adminSiteClient/ChartIndexPage.tsx
@@ -12,6 +12,7 @@ import {
     highlightFunctionForSearchWords,
     SearchWord,
 } from "../adminShared/search.js"
+import { sortNumeric, SortOrder } from "@ourworldindata/utils"
 
 @observer
 export class ChartIndexPage extends React.Component {
@@ -56,13 +57,11 @@ export class ChartIndexPage extends React.Component {
 
         // Apply sorting if needed
         if (sortConfig?.field === "pageviewsPerDay") {
-            return [...filtered].sort((a, b) => {
-                const aValue = a.pageviewsPerDay || 0
-                const bValue = b.pageviewsPerDay || 0
-                return sortConfig.direction === "desc"
-                    ? bValue - aValue
-                    : aValue - bValue
-            })
+            return sortNumeric(
+                [...filtered],
+                (chart) => chart.pageviewsPerDay,
+                sortConfig.direction === "asc" ? SortOrder.asc : SortOrder.desc
+            )
         }
 
         return filtered

diff --git a/adminSiteClient/EditorReferencesTab.tsx b/adminSiteClient/EditorReferencesTab.tsx
@@ -13,6 +13,7 @@ import {
     formatValue,
     ChartRedirect,
     partition,
+    round,
 } from "@ourworldindata/utils"
 import { AbstractChartEditor, References } from "./AbstractChartEditor.js"
 import {
@@ -214,9 +215,7 @@ export class EditorReferencesTabForChart extends React.Component<{
                             </strong>{" "}
                             {this.renderPageview(
                                 this.pageviews?.views_365d
-                                    ? Math.round(
-                                          this.pageviews?.views_365d / 36.5
-                                      ) / 10
+                                    ? round(this.pageviews?.views_365d / 365, 1)
                                     : undefined
                             )}
                         </div>