Skip to content

Conversation

@Gacko
Copy link
Contributor

@Gacko Gacko commented Dec 9, 2025

This fixes builds on Alpine v3.23.0 (GCC v15.2.0, musl v1.2.5).

headers/modsecurity/collection/collection.h:x:x: error: 'int32_t' has not been declared
headers/modsecurity/collection/collection.h:x:x: note: 'int32_t' is defined in header '<cstdint>'; this is probably fixable by adding '#include <cstdint>'

This fixes builds on Alpine v3.23.0 (GCC v15.2.0, musl v1.2.5).
Copilot AI review requested due to automatic review settings December 9, 2025 06:51
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a build error on Alpine v3.23.0 (GCC v15.2.0, musl v1.2.5) by adding the missing <cstdint> header include, which is required for the int32_t type used in the Collection class.

  • Adds #include <cstdint> to provide the int32_t type definition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2025

@airween
Copy link
Member

airween commented Dec 9, 2025

Just a side note: the referenced type (int32_t) is used here.

And one question: is there no other file where it is missing?

@Gacko
Copy link
Contributor Author

Gacko commented Dec 9, 2025

And one question: is there no other file where it is missing?

I haven't checked, but we're relying on it in Ingress NGINX and this change made the build of our NGINX base image work: https://github.com/kubernetes/ingress-nginx/blob/main/images/nginx/rootfs/build.sh#L337-L367.

@airween airween merged commit cebcde3 into owasp-modsecurity:v3/master Dec 9, 2025
56 checks passed
@airween
Copy link
Member

airween commented Dec 9, 2025

@Gacko: thanks for this patch!

@Gacko Gacko deleted the patch-1 branch December 9, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants