-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add CMake and CI Pipeline for ModSecurityIIS in ModSecurity V2 #3452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMake and CI Pipeline for ModSecurityIIS in ModSecurity V2 #3452
Conversation
…Security into v2/test-ci-windows
|
Hi @A13501350, first of all, many thanks for this PR.
What kind of testing you think about? Do you want to add them before the merge (I mean are you still working on it?)?
A readme would be grateful, I would add that into our Wiki that describe how to make module for IIS on Windows. That could contain these dependencies too. What do you think? |
|
And one more thing: could you pick up your last PR (#3443) into this PR? I think a rebase from v2/master would be enough. Just see it works as we expect. Thanks! |
|
@A13501350, please take a look at the SonarCloud issues: |
I tried using the full commit hash msys2/setup-msys2@847bbeb, but it didn't work. Also, since this dependency updates frequently, I'm not sure if pinning to a specific commit is the best approach. |
No worries, at this time it would be enough to add a stable IIS build on Windows. Just make those lines as comment. Probably the Sonar issues will disappear too. |
|
I noticed ssdeep was disabled in commit b02256c, but after testing, ssdeep appears to compile and link normally with no apparent functionality impact, so I've re-enabled it. |
|
Though it does require msys2 for compilation |
I see. Then let's see how can you solve that (it would be nice to disappear the Sonar issue). |
|
|
Done. However, there are other actions using tags instead of SHA hashes, and I believe the best practice is to use a bot like Dependabot to check for updates. |
|
Thanks! I think that's excellent now!
yes, you're right, we should involve that. |



What
Why
Note: