fix: ignore case when evaluating exceptions #3442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theseion
requested changes
Sep 17, 2025
test/test-cases/regression/action-ctl_rule_remove_target_by_id.json
Outdated
Show resolved
Hide resolved
test/test-cases/regression/action-ctl_rule_remove_target_by_id.json
Outdated
Show resolved
Hide resolved
….json Co-authored-by: Max Leske <[email protected]>
….json Co-authored-by: Max Leske <[email protected]>
|
theseion
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR fixes the wrong behavior: variable names are treated as case sensitive. Also it contains two new test cases for regression tests.
why
An issue opened (see below) where the reporter explained the problem: if an exclusion adds a collection member with lowercase, it won't have any effect during the rule evaluation.
The issue mentions only the
REQUEST_HEADERScollection, but that's true for all targets.mod_security2 Apache module uses
strncasecmp()in all cases, not justREQUEST_HEADERS.additional notes
I didn't want to mix C and C++ functions, this is why I ignored
strncasecmp(). I also wanted to avoid copying strings and create new functions to comparing strings, so the only solution seemed to be to usestd::equal()with a lambda function.references
#3441