Skip to content

chore: bump version in MSI installer.wxs #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

airween
Copy link
Member

@airween airween commented Jun 10, 2025

what

This PR sets the correct version string in MSI installer file.

why

There is a user report about the wrong version string.

references

See #3399 for the report.

@airween airween requested review from theseion and fzipi June 10, 2025 08:57
Copy link
Contributor

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be cleaned up. There is a lot of commented stuff (e.g. old crs versions). Also, do you know which pcre version is used by default in the windows build? It should be using the newer version also, right?

Co-authored-by: Felipe Zipitría <[email protected]>
Copy link

@airween
Copy link
Member Author

airween commented Jun 10, 2025

This file should be cleaned up.

Yes, definitely, it should.

There is a lot of commented stuff (e.g. old crs versions). Also, do you know which pcre version is used by default in the windows build? It should be using the newer version also, right?

I have no idea. Unfortunately, I don't have any Windows and can't check the build flow. I know this is a big problem, because there is another Windows related issue (#3397). But for that (and for this too) we need not just a Windows, but an IIS too.

@airween airween requested a review from fzipi June 10, 2025 14:14
@airween airween requested review from theseion and removed request for theseion June 10, 2025 14:54
@airween airween merged commit 348005a into owasp-modsecurity:v2/master Jun 11, 2025
82 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants