Skip to content

Conversation

@JayBeeDe
Copy link
Member

@JayBeeDe JayBeeDe commented Oct 28, 2025

Description

Issue in API call POST /dedicated/server/{serviceName}/reinstall, properties attribute is not taken into account in OS installation.
Since custom config drive (cloud init datasource) metadata doesn't make sense for some OSes such as Windows, it has been decided to move those custom config drive metadata under customizations attribute in customizations.configDriveMetadata, since it's an OS-dependent configuration.
This PR

  • is about marking this properties field as deprecated
  • is adding the attribute customizations.configDriveMetadata

Upcoming PR !1019 will definitely remove the properties attribute

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (improve existing resource(s) or datasource(s))
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A: make testacc --debug TESTARGS="-run TestAccDedicatedServerReinstall_byolinux"
GNU Make 4.3
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Reading makefiles...
Updating makefiles....
Updating goal targets....
 File 'testacc' does not exist.
   File 'fmtcheck' does not exist.
  Must remake target 'fmtcheck'.
==> Checking that code complies with gofmt requirements...
  Successfully remade target file 'fmtcheck'.
Must remake target 'testacc'.
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccDedicatedServerReinstall_byolinux -timeout 600m -p 10
?   	github.com/ovh/terraform-provider-ovh/v2	[no test files]
=== RUN   TestAccDedicatedServerReinstall_byolinux
--- PASS: TestAccDedicatedServerReinstall_byolinux (487.16s)
PASS
ok  	github.com/ovh/terraform-provider-ovh/v2/ovh	487.179s
?   	github.com/ovh/terraform-provider-ovh/v2/ovh/datasources/cloud_project_rancher	[no test files]
?   	github.com/ovh/terraform-provider-ovh/v2/ovh/helpers	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/ovh/terraform-provider-ovh/v2/ovh/helpers/hashcode	(cached) [no tests to run]
?   	github.com/ovh/terraform-provider-ovh/v2/ovh/ovhwrap	[no test files]
?   	github.com/ovh/terraform-provider-ovh/v2/ovh/resources/cloud_project_rancher	[no test files]
?   	github.com/ovh/terraform-provider-ovh/v2/ovh/types	[no test files]
Successfully remade target file 'testacc'.

Reinstall task 497393202 was successfully performed on server ns3068389.ip-137-74-4.eu

  • [] Test B: make testacc --debug TESTARGS="-run TestAccDedicatedServerReinstall_basic"
GNU Make 4.3
Built for x86_64-pc-linux-gnu
Copyright (C) 1988-2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Reading makefiles...
Updating makefiles....
Updating goal targets....
 File 'testacc' does not exist.
   File 'fmtcheck' does not exist.
  Must remake target 'fmtcheck'.
==> Checking that code complies with gofmt requirements...
  Successfully remade target file 'fmtcheck'.
Must remake target 'testacc'.
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccDedicatedServerReinstall_basic -timeout 600m -p 10
?   	github.com/ovh/terraform-provider-ovh/v2	[no test files]
=== RUN   TestAccDedicatedServerReinstall_basic
--- PASS: TestAccDedicatedServerReinstall_basic (843.77s)
PASS
ok  	github.com/ovh/terraform-provider-ovh/v2/ovh	843.788s
?   	github.com/ovh/terraform-provider-ovh/v2/ovh/datasources/cloud_project_rancher	[no test files]
?   	github.com/ovh/terraform-provider-ovh/v2/ovh/helpers	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/ovh/terraform-provider-ovh/v2/ovh/helpers/hashcode	(cached) [no tests to run]
?   	github.com/ovh/terraform-provider-ovh/v2/ovh/ovhwrap	[no test files]
?   	github.com/ovh/terraform-provider-ovh/v2/ovh/resources/cloud_project_rancher	[no test files]
?   	github.com/ovh/terraform-provider-ovh/v2/ovh/types	[no test files]
Successfully remade target file 'testacc'.

Reinstall task 497394634 was successfully performed on ns3168100.ip-51-195-234.eu

Test Configuration:

  • Terraform version: terraform version: Terraform v1.12.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • [] I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran successfully go mod vendor if I added or modify go.mod file

@JayBeeDe JayBeeDe requested a review from a team as a code owner October 28, 2025 10:48
@JayBeeDe JayBeeDe force-pushed the fix/PUBM-43183-deprecated branch from b8262d0 to 73da967 Compare October 28, 2025 10:49
@JayBeeDe JayBeeDe force-pushed the fix/PUBM-43183-deprecated branch from cf25f7b to 0ff54cc Compare October 28, 2025 15:04
@JayBeeDe JayBeeDe changed the title fix(dedicated_server{,_reinstall_task}): mark properties as deprecated feat(dedicated_server{,_reinstall_task}): mark properties as deprecated and add customizations.config_drive_metadata Oct 28, 2025
…rive_metadata

ref: #PUBM-43183
Signed-off-by: Jean-Baptiste Delon <[email protected]>
@JayBeeDe JayBeeDe force-pushed the fix/PUBM-43183-deprecated branch from 0ff54cc to 59aaeba Compare October 29, 2025 13:42
@amstuta amstuta merged commit 721e7b7 into master Oct 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants