feat(dedicated_server{,_reinstall_task}): mark properties as deprecated and add customizations.config_drive_metadata #1135
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue in API call
POST /dedicated/server/{serviceName}/reinstall,propertiesattribute is not taken into account in OS installation.Since custom config drive (cloud init datasource) metadata doesn't make sense for some OSes such as Windows, it has been decided to move those custom config drive metadata under customizations attribute in
customizations.configDriveMetadata, since it's an OS-dependent configuration.This PR
propertiesfield as deprecatedcustomizations.configDriveMetadataUpcoming PR !1019 will definitely remove the
propertiesattributeType of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
make testacc --debug TESTARGS="-run TestAccDedicatedServerReinstall_byolinux"Reinstall task 497393202 was successfully performed on server ns3068389.ip-137-74-4.eu
make testacc --debug TESTARGS="-run TestAccDedicatedServerReinstall_basic"Reinstall task 497394634 was successfully performed on ns3168100.ip-51-195-234.eu
Test Configuration:
terraform version: Terraform v1.12.2Checklist:
go mod vendorif I added or modifygo.modfile