Skip to content

Commit

Permalink
doc: add go report card to readme
Browse files Browse the repository at this point in the history
Signed-off-by: Pierre-Henri Symoneaux <[email protected]>
  • Loading branch information
phsym committed Nov 13, 2024
1 parent 46b8e74 commit c17f647
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# okms-cli
[![build](https://github.com/ovh/okms-cli/actions/workflows/build.yaml/badge.svg?branch=main)](https://github.com/ovh/okms-cli/actions/workflows/build.yaml)
[![license](https://img.shields.io/badge/license-Apache%202.0-red.svg?style=flat)](https://raw.githubusercontent.com/ovh/okms-sdk-go/master/LICENSE)
[![license](https://img.shields.io/badge/license-Apache%202.0-red.svg?style=flat)](https://raw.githubusercontent.com/ovh/okms-sdk-go/master/LICENSE) [![Go Report Card](https://goreportcard.com/badge/github.com/ovh/okms-cli)](https://goreportcard.com/report/github.com/ovh/okms-cli)

The CLI to interact with your [OVHcloud KMS](https://help.ovhcloud.com/csm/en-ie-kms-quick-start?id=kb_article_view&sysparm_article=KB0063362) services.

Expand Down
2 changes: 1 addition & 1 deletion common/config/yubikey.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func (epCfg *yubikeyAuth) TlsCertificates() []tls.Certificate {

// FIXME: Where / How to close the connection ?
// The issue preventing us from deferring the close is that we
// return a tls.Certificate thta have a remote private key / signer that requires
// return a tls.Certificate that have a remote private key / signer that requires
// the connection to stay open. Anyway, the connection will be closed on program exit, so we may not
// need to close it by ourself. However it would be cleaner.
// defer yubiKey.Close()
Expand Down

0 comments on commit c17f647

Please sign in to comment.