-
Notifications
You must be signed in to change notification settings - Fork 106
Feat/add instance quantity tapc 4680 #18576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
manoncarbonnel
wants to merge
1
commit into
feat/add-instance-creation-page-TAPC-4445
Choose a base branch
from
feat/add-instance-quantity-TAPC-4680
base: feat/add-instance-creation-page-TAPC-4445
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/add instance quantity tapc 4680 #18576
manoncarbonnel
wants to merge
1
commit into
feat/add-instance-creation-page-TAPC-4445
from
feat/add-instance-quantity-TAPC-4680
+180
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52bb664
to
ca5a269
Compare
Base automatically changed from
feat/add-instance-name-input-creation-TAPC-4541
to
feat/add-instance-creation-page-TAPC-4445
August 8, 2025 09:04
783887c
to
a9299dc
Compare
b0f7818
to
c10f4fd
Compare
packages/manager/apps/pci-instances/src/pages/instances/create/CreateInstance.page.tsx
Outdated
Show resolved
Hide resolved
Tsiorifamonjena
approved these changes
Aug 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 👌🏽
packages/manager/apps/pci-instances/src/components/cart/Cart.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-instances/src/pages/instances/create/CreateInstance.page.tsx
Outdated
Show resolved
Hide resolved
c10f4fd
to
3d1a95e
Compare
a97c440
to
03c6367
Compare
SimonChaumet
approved these changes
Aug 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except lint errors, all good
03c6367
to
77e0fcb
Compare
ref: #TAPC-4680 Signed-off-by: Manon Carbonnel <[email protected]>
77e0fcb
to
e022365
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Static form field for instance quantity.
Ticket Reference: #4680