Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-cold-archive): add modal to archive container #15367

Merged
merged 1 commit into from
Feb 10, 2025
Merged

feat(pci-cold-archive): add modal to archive container #15367

merged 1 commit into from
Feb 10, 2025

Conversation

kqesar
Copy link
Contributor

@kqesar kqesar commented Feb 7, 2025

ref: DTCORE-3074

Question Answer
Branch? feat/pci-cold-archive
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets DTCORE-3074
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@kqesar kqesar requested review from a team as code owners February 7, 2025 14:31
@kqesar kqesar requested review from ghyenne, darsene, sidlynx, frenautvh and qpavy and removed request for a team February 7, 2025 14:31
@github-actions github-actions bot added translation required dependencies Pull requests that update a dependency file feature New feature labels Feb 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@ovhcloud/ods-components UPDATED 18.5.0 18.5.1
@ovhcloud/ods-themes UPDATED 18.5.0 18.5.1

@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Feb 7, 2025
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Feb 7, 2025
@kqesar kqesar force-pushed the feat/DTCORE-3074 branch 2 times, most recently from a35330c to 369f3e3 Compare February 7, 2025 16:09
@kqesar
feat(pci-cold-archive): add modal to archive container
ac5a93d 
ref: DTCORE-3074
Signed-off-by: Yoann Fievez <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kqesar kqesar merged commit cd4eb9f into feat/pci-cold-archive Feb 10, 2025
13 of 14 checks passed
@kqesar kqesar deleted the feat/DTCORE-3074 branch February 10, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenautvh frenautvh frenautvh approved these changes

@rjamet-ovh rjamet-ovh rjamet-ovh approved these changes

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kqesar @frenautvh @rjamet-ovh