Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(*): implement changelog button on angular stack #15174

Open
wants to merge 10 commits into
base: feat/MANAGER-16546-angular
Choose a base branch
from
Open

feat(*): implement changelog button on angular stack #15174

wants to merge 10 commits into from

Conversation

MaximeBajeux
Copy link
Contributor

ref:

Question Answer
Branch? feat/MANAGER-16546-angular
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-16546
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Implementation of the changelog button on angular stack

Related

@MaximeBajeux MaximeBajeux requested a review from a team as a code owner January 29, 2025 09:37
@MaximeBajeux MaximeBajeux requested review from qpavy, anooparveti and JacquesLarique and removed request for a team January 29, 2025 09:37
@MaximeBajeux MaximeBajeux changed the title feat(*): implement changelog button on bare metal feat(*): implement changelog button on angular stack Feb 3, 2025
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-16546-impl-angular branch from 2b7d8d8 to f9c308d Compare February 5, 2025 13:28
SimonChaumet
SimonChaumet approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@SimonChaumet SimonChaumet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could have been factorized between different apps, especially in pci where it imports the constant and it's the same markup for every app

@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-16546-angular branch from 21bd202 to a9890c0 Compare February 6, 2025 17:16
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-16546-impl-angular branch from 04b3094 to 1271c5f Compare February 6, 2025 17:19
CDS Translator Agent added 10 commits February 7, 2025 15:20
@ovh-cds
fix(i18n): add missing translations [CDS 217]
fd97e65 
Signed-off-by: CDS Translator Agent <[email protected]>
feat(manager-components): fix css issue
686b248 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
feat(*): implement changelog button on bare metal
56e5930 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
feat(*): add changelog button on hpc and network universes
3ef6a00 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
feat(web): implement changelog button
63a3fb4 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
feat(telecom): add changelog button
587bcba 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
fix(dedicated): fix changelog with bad variable
d7a926c 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
feat(pci): implement changelog button into pci angular
35ac762 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
fix(dedicated): fix injection error on baremetal
ce9bbd4 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
fix(dedicated): fix injection error on servers
c17e56b 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-16546-impl-angular branch from f5f5ac0 to c17e56b Compare February 7, 2025 16:42
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2025

Quality Gate Passed Quality Gate passed

Issues
48 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-16546-angular branch from 686b248 to bf5b83f Compare February 7, 2025 17:48
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonChaumet SimonChaumet SimonChaumet approved these changes

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
common feature New feature has conflicts Has conflicts to resolve before merging universe-bare-metal-cloud universe-hosted-private-cloud universe-public-cloud universe-telecom universe-web-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaximeBajeux @SimonChaumet