Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci.ai.notebook): update guide, fix console error and wording #15076

Merged
merged 2 commits into from
Jan 29, 2025
Merged

feat(pci.ai.notebook): update guide, fix console error and wording #15076

merged 2 commits into from
Jan 29, 2025

Conversation

abullet33
Copy link
Contributor

Question Answer
Branch? master / release/** / develop
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@abullet33 abullet33 requested review from a team as code owners January 23, 2025 11:09
@abullet33 abullet33 requested review from aottr, stif59100, sidlynx, seven-amid, anooparveti and darsene and removed request for a team January 23, 2025 11:09
@abullet33 abullet33 requested a review from jperchoc January 28, 2025 16:18
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@abullet33 abullet33 merged commit 78104d4 into feat/pci-ai-notebook-update-link Jan 29, 2025
13 of 14 checks passed
@abullet33 abullet33 deleted the feat/pci-ai-notebook-guides-and-final-clean branch January 29, 2025 14:40
abullet33 added a commit that referenced this pull request Jan 29, 2025
@abullet33
feat(pci.ai.notebook): update link in dashboard tabs (#15030)
073786d 
* feat(pci.ai.notebook): update link in dashboard tabs
* feat(pci.ai.notebook): update guide, fix console error and wording (#15076)
* feat(pci.ai.notebook): update guide, fix console error and wording
* feat(pci.ai.notebook): fix pr comments
Signed-off-by: Arthur Bullet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jperchoc jperchoc jperchoc approved these changes

@aottr aottr Awaiting requested review from aottr aottr was automatically assigned from ovh/team-manager-dev-reactjs

@stif59100 stif59100 Awaiting requested review from stif59100 stif59100 was automatically assigned from ovh/team-manager-dev-reactjs

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti was automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abullet33 @jperchoc