Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager-react-component): add manager tile component #15066

Merged
merged 1 commit into from
Jan 23, 2025
Merged

feat(manager-react-component): add manager tile component #15066

merged 1 commit into from
Jan 23, 2025
+241 −0

Conversation

tibs245
Copy link
Contributor

@tibs245 tibs245 commented Jan 23, 2025 •
edited
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? no
Breaking change? no (But can introduce deprecation of dashboard-tile)
Tickets Fix #MANAGER-16641
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Screenshot 2025-01-23 at 13 50 42

Related

@tibs245 tibs245 requested review from a team as code owners January 23, 2025 08:22
@github-actions github-actions bot added the feature New feature label Jan 23, 2025
@tibs245 tibs245 force-pushed the feat/mrc-add-manager-tile branch 2 times, most recently from a5fd7a7 to fe1942b Compare January 23, 2025 12:51
tristanwagner
tristanwagner previously approved these changes Jan 23, 2025
View reviewed changes
rjamet-ovh
rjamet-ovh previously approved these changes Jan 23, 2025
View reviewed changes
@tibs245 tibs245 linked an issue Jan 23, 2025 that may be closed by this pull request
[manager-components]: Add manager tile component #15083
Open
1 task
@tibs245 tibs245 dismissed stale reviews from rjamet-ovh and tristanwagner via 67ee94b January 23, 2025 16:32
@tibs245 tibs245 force-pushed the feat/mrc-add-manager-tile branch from fe1942b to 67ee94b Compare January 23, 2025 16:32
@tibs245 tibs245 requested a review from a team as a code owner January 23, 2025 16:32
@tibs245 tibs245 requested a review from sachinrameshn January 23, 2025 16:32
tibs245 added a commit that referenced this pull request Jan 23, 2025
@tibs245
feat(manager-react-component): add manager tile component
a06a105 
It's a duplicated of dashboard tile but with a Compound components pattern

Resolve #15066

Signed-off-by: Thibault Barske <[email protected]>
@tibs245 tibs245 force-pushed the feat/mrc-add-manager-tile branch from 67ee94b to a06a105 Compare January 23, 2025 16:33
tristanwagner
tristanwagner previously approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@tristanwagner tristanwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding @ovh-ux/manager-common-translations to peerDependencies might be a breaking change

rjamet-ovh
rjamet-ovh previously approved these changes Jan 23, 2025
View reviewed changes
@tibs245
feat(manager-react-component): add manager tile component
04fe3d1 
It's a duplicated of dashboard tile but with a Compound components pattern

Resolve #15066

Signed-off-by: Thibault Barske <[email protected]>
@tibs245 tibs245 dismissed stale reviews from rjamet-ovh and tristanwagner via 04fe3d1 January 23, 2025 16:56
@tibs245 tibs245 force-pushed the feat/mrc-add-manager-tile branch from a06a105 to 04fe3d1 Compare January 23, 2025 16:56
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
10.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@tibs245 tibs245 merged commit 4aae0ae into develop Jan 23, 2025
15 of 16 checks passed
@tibs245 tibs245 deleted the feat/mrc-add-manager-tile branch January 23, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjamet-ovh rjamet-ovh rjamet-ovh approved these changes

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud aboungnaseng-ovhcloud approved these changes

@tristanwagner tristanwagner tristanwagner left review comments

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[manager-components]: Add manager tile component
4 participants
@tibs245 @tristanwagner @aboungnaseng-ovhcloud @rjamet-ovh