Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pci private registry fix style tile tapc 2646 #15057

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix/pci private registry fix style tile tapc 2646 #15057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10c3d29
fix(i18n): add missing translations [CDS 3343]
ovh-ux-cds Sep 27, 2024
6cc87c9
fix(pci.private-registry): css update of PlanChooser Tile
Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions packages/manager/apps/pci-private-registry/src/components/Plan.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ export default function PlanComponent({
const { formatBytes } = useBytes();

return (
<div className="w-full">
<div className="border-solid border border-t-0 border-x-0 border-[--ods-color-blue-200] my-4 py-4 mx-8">
<div className="grid grid-cols-1 gap-2 text-left text w-full">
<div className="text-center">
<OsdsText
data-testid="name"
color={ODS_THEME_COLOR_INTENT.text}
Expand All @@ -54,9 +54,10 @@ export default function PlanComponent({
>
{plan.name[0]}
</OsdsText>
<hr className="w-full border-solid border-0 border-b border-b-[#85d9fd]" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this color in the ui kit ?

</div>
{isPending && (
<div className="min-h-[10rem] mx-6">
<div className="min-h-[10rem] mx-6 text-center">
<OsdsSkeleton />
<OsdsSkeleton />
<OsdsSkeleton />
Expand All @@ -65,7 +66,7 @@ export default function PlanComponent({
</div>
)}
{!isPending && (
<ul className="list-none p-0 m-0 min-h-[8rem] mx-8">
<ul className="list-none p-0 min-h-[8rem] mx-8">
<li data-testid="capacity">
<OsdsText
color={ODS_THEME_COLOR_INTENT.text}
Expand Down Expand Up @@ -150,12 +151,8 @@ export default function PlanComponent({
)}
</ul>
)}
<div
className={clsx(
'border-solid border border-b-0 border-x-0 border-[--ods-color-blue-200] mb-2 pt-4 mt-9 text-center py-4',
)}
data-testid="price"
>
<div data-testid="price">
<hr className="w-full border-solid border-0 border-b border-b-[#85d9fd]" />
<OsdsText
color={ODS_THEME_COLOR_INTENT.text}
level={ODS_THEME_TYPOGRAPHY_LEVEL.body}
Expand Down
1 change: 0 additions & 1 deletion packages/manager/apps/pci-private-registry/src/components/PlanChooser.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export default function PlanChooser({
onInput(v);
}}
label={(item) => <PlanComponent plan={item} />}
tileClass={{ active: 'p-0', inactive: 'p-0' }}
/>
);
}
Loading