Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(container): refacor livechat component #15055

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

feat(container): refacor livechat component #15055

wants to merge 4 commits into from

Conversation

aottr
Copy link
Contributor

@aottr aottr commented Jan 22, 2025

ref: MANAGER-15587

Question Answer
Branch? master / release/** / develop
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@aottr aottr requested review from a team as code owners January 22, 2025 16:31
@aottr aottr marked this pull request as draft January 22, 2025 16:31
@aottr aottr changed the base branch from master to develop January 22, 2025 16:31
@aottr aottr force-pushed the feat/MANAGER-15587 branch 6 times, most recently from 49c70b4 to ec39109 Compare January 24, 2025 11:44
@aottr
feat(container): refacor livechat component
47369ea 
ref: MANAGER-15587

Signed-off-by: Dustin Kroger <[email protected]>
@aottr aottr force-pushed the feat/MANAGER-15587 branch from ec39109 to 47369ea Compare January 24, 2025 11:51
aottr added 3 commits January 24, 2025 15:15
@aottr
feat(container): add tests to livechat component
fc3f8fc 
ref: MANAGER-16561

Signed-off-by: Dustin Kroger <[email protected]>
@aottr
feat(container): address recommendations and remove testing probes
57bad7e 
ref: MANAGER-15587

Signed-off-by: Dustin Kroger <[email protected]>
@aottr
feat(container): add function to close SNOW session
56d00a3 
ref: MANAGER-15587

Signed-off-by: Dustin Kroger <[email protected]>
@aottr aottr force-pushed the feat/MANAGER-15587 branch from 7905710 to 56d00a3 Compare January 31, 2025 16:58
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 31, 2025
View reviewed changes
packages/manager/apps/container/src/container/livechat/LiveChat.component.tsx
setChatbotReduced(false);

if (chatType === 'SNOW' && chatIFrame.current) {
chatIFrame.current.contentWindow?.postMessage(

Check failure

Code scanning / SonarCloud

Origins should be verified during cross-origin communications High

Specify a target origin for this message. See more on SonarQube Cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
container feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aottr