Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mrc): add changelog component to mrc v1.x #14895

Merged
merged 14 commits into from
Feb 11, 2025
Merged

feat(mrc): add changelog component to mrc v1.x #14895

merged 14 commits into from
Feb 11, 2025

Conversation

MaximeBajeux
Copy link
Contributor

Question Answer
Branch? maintenance/manager-react-components-v1.x
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets MANAGER-16546
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@MaximeBajeux MaximeBajeux requested review from a team as code owners January 14, 2025 09:38
Maxime Bajeux added 5 commits January 16, 2025 18:05
feat(mrc): add changelog component to mrc v1.x
181d28c 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
feat(mrc): export new component changelog
4a40bc3 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
feat(mrc): unify translations
cedb4ef 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
feat(mrc): clean translations
3fd4a53 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
feat(mrc): refacto changelog menu component
34f0177 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
@MaximeBajeux MaximeBajeux force-pushed the feat/MANAGER-16546-mrc-legacy branch from c48d7dd to 34f0177 Compare January 17, 2025 11:24
Maxime Bajeux added 5 commits January 20, 2025 11:25
feat(mrc): refacto component changelog
2c08559 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
feat(mrc): make chapters optionnal
afddd76 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
@ovh-cds
fix(i18n): add missing translations [CDS 3676]
689fb34 
Signed-off-by: CDS Translator Agent <[email protected]>
fix(mrc): fix lint import error
3171c87 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
feat(mrc): fix header test
772af4b 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
@MaximeBajeux MaximeBajeux self-assigned this Feb 4, 2025
@MaximeBajeux MaximeBajeux linked an issue Feb 4, 2025 that may be closed by this pull request
[manager-components]: Changelog Button component #15281
Closed
1 task
JacquesLarique
JacquesLarique previously approved these changes Feb 5, 2025
View reviewed changes
qpavy
qpavy previously approved these changes Feb 6, 2025
View reviewed changes
oalkabouss
oalkabouss previously approved these changes Feb 6, 2025
View reviewed changes
feat(mrc): fix capital letter issue
1c8315c 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
@MaximeBajeux MaximeBajeux dismissed stale reviews from oalkabouss and qpavy via 1c8315c February 7, 2025 17:56
CDS Translator Agent added 3 commits February 7, 2025 17:58
@ovh-cds
fix(i18n): add missing translations [CDS 220]
3561cc2 
Signed-off-by: CDS Translator Agent <[email protected]>
feat(mrc): update component to pass changelog on separate prop
d033e9f 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
fix(mrc): fix header component
886cfee 
ref: MANAGER-16546

Signed-off-by: Maxime Bajeux <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anooparveti anooparveti merged commit 62aa77b into maintenance/manager-react-components-v1.x Feb 11, 2025
13 of 14 checks passed
@anooparveti anooparveti deleted the feat/MANAGER-16546-mrc-legacy branch February 11, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacquesLarique JacquesLarique JacquesLarique approved these changes

@qpavy qpavy qpavy left review comments

@oalkabouss oalkabouss oalkabouss left review comments

@aottr aottr Awaiting requested review from aottr aottr is a code owner automatically assigned from ovh/team-manager-dev-reactjs

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

Assignees

@MaximeBajeux MaximeBajeux

Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[manager-components]: Changelog Button component
5 participants
@MaximeBajeux @qpavy @oalkabouss @JacquesLarique @anooparveti